Align: out-layout-preset (inject ADR 0007 out/ defaults) - #1
Merged
Conversation
Record light-align decisions and clarify Conventional role outputs in the glossary so unset distPath stops falling back to roleRoot/dist. Co-authored-by: Zane <guangzan1999@outlook.com>
Add spec.md and issues for normalizeRuntime distPath preset injection plus docs/examples alignment. Co-authored-by: Zane <guangzan1999@outlook.com>
normalizeRuntime now presets out/<role> under the application root; unit tests cover injection and explicit overrides. Co-authored-by: Zane <guangzan1999@outlook.com>
Update getting-started/migration, point example package.json#main at out/main, refresh BUILD-001 evidence, and assert docs-site copy. Co-authored-by: Zane <guangzan1999@outlook.com>
Keep the approachable getting-started gate free of bare Role terminology. Co-authored-by: Zane <guangzan1999@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement
out-layout-preset: whenoutput.distPathis unset, Role preset injects Conventional role outputs underout/{main,preload,renderer}at the application root (ADR 0007 / BUILD-001).Changes
applyConventionalDistPathinnormalizeRuntime— absoluteresolve(appRoot, 'out', role); explicit string / object-with-rootpreserved; object missingrootgets injection while keeping siblingstests/unit/electron-runtime.test.tscovers injection + overrides;plannedMainEntrylands underout/main/index.mjsfortype:moduleout/<role>as the unset default; early-beta<roleRoot>/distcalled outpackage.json#main→./out/main/index.mjsRail artifacts
docs/monorail/out-layout-preset/align.mddocs/monorail/out-layout-preset/spec.md01/02marked doneOut of scope (per align)
Renderer
assetPrefix, zero-config discovery, window-load helpers, packaging, default watch, implicitshared